Re: [PATCH 2/3] scsi: make io_timeout configurable

[Paolo Bonzini]

On 22/09/21 17:47, Philippe Mathieu-Daudé wrote:
> >
>
> > @@ -637,7 +639,7 @@ static int get_stream_blocksize(BlockBackend *blk)
> >       cmd[0] = MODE_SENSE;
> >       cmd[4] = sizeof(buf);
> > -    ret = scsi_SG_IO_FROM_DEV(blk, cmd, sizeof(cmd), buf, sizeof(buf));
> > +    ret = scsi_SG_IO_FROM_DEV(blk, cmd, sizeof(cmd), buf, 
> > sizeof(buf), 6);
>
> Why is this timeout hardcoded? Due to the /* XXX */ comment?

This command is only invoked at startup and involves no I/O, so 6 
seconds should be plenty.

Paolo