Re: [PATCH v2 03/30] tcg/loongarch64: Add the tcg-target.h file

[WANG Xuerui]

Hi Richard,

On 9/22/21 11:55, Richard Henderson wrote:
> On 9/21/21 1:18 PM, WANG Xuerui wrote:
> > Signed-off-by: WANG Xuerui<git@xen0n.name>
> > ---
> >   tcg/loongarch64/tcg-target.h | 180 +++++++++++++++++++++++++++++++++++
> >   1 file changed, 180 insertions(+)
> >   create mode 100644 tcg/loongarch64/tcg-target.h
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>
> However...
>
>
> > +#define TCG_TARGET_HAS_sub2_i32         0
> > +#define TCG_TARGET_HAS_mulu2_i32        0
> > +#define TCG_TARGET_HAS_muls2_i32        0
> > +#define TCG_TARGET_HAS_muluh_i32        1
> > +#define TCG_TARGET_HAS_mulsh_i32        1
> > +#define TCG_TARGET_HAS_ext8s_i32        1
> > +#define TCG_TARGET_HAS_ext16s_i32       1
> > +#define TCG_TARGET_HAS_ext8u_i32        1
> > +#define TCG_TARGET_HAS_ext16u_i32       1
> > +#define TCG_TARGET_HAS_bswap16_i32      0
>
> It might be better to enable these with the patch that adds the insns.
Sounds like a good idea, I'll re-organize to enable these individually 
in each commit in v3.
> r~