[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 1/6] Acceptance Tests: add standard clean up at test tearDown()
From: |
Willian Rampazzo |
Subject: |
[PATCH 1/6] Acceptance Tests: add standard clean up at test tearDown() |
Date: |
Mon, 20 Sep 2021 17:49:27 -0300 |
From: Cleber Rosa <crosa@redhat.com>
The avocado.Test class, used as the basis of the avocado_qemu.Test
class, performs a clean of temporary directories up as part of its own
tearDown() implementation.
But the avocado_qemu.Test class is currently missing the same clean
up, as it implemented its own tearDown() method without resorting to
the upper class behavior.
This brings avocado_qemu.Test behavior in sync with the standard
avocado.Test behavior and prevents temporary directories from
cluttering the test results directory (unless instructed to do so with
Avocado's "--keep-tmp" option).
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Cleber Rosa <crosa@redhat.com>
[willianr: respin to new Python super format]
Signed-off-by: Willian Rampazzo <willianr@redhat.com>
---
v2
- adjust super call to conform with PEP3135
---
tests/acceptance/avocado_qemu/__init__.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/acceptance/avocado_qemu/__init__.py
b/tests/acceptance/avocado_qemu/__init__.py
index 2c4fef3e14..d9e1b32aa1 100644
--- a/tests/acceptance/avocado_qemu/__init__.py
+++ b/tests/acceptance/avocado_qemu/__init__.py
@@ -276,6 +276,7 @@ def tearDown(self):
for vm in self._vms.values():
vm.shutdown()
self._sd = None
+ super().tearDown()
def fetch_asset(self, name,
asset_hash=None, algorithm=None,
--
2.31.1
- [PATCH 0/6] avocado_qemu: small fixes and tweaks, Willian Rampazzo, 2021/09/20
- [PATCH 2/6] avocado_qemu: standardize supper() call following PEP3135, Willian Rampazzo, 2021/09/20
- [PATCH 1/6] Acceptance Tests: add standard clean up at test tearDown(),
Willian Rampazzo <=
- [PATCH 3/6] avocado_qemu: fix import module based on isort, Willian Rampazzo, 2021/09/20
- [PATCH 4/6] avocado_qemu: tweak ssh connect method, Willian Rampazzo, 2021/09/20
- [PATCH 5/6] avocado_qemu: explicitly return None to avoid R1710, Willian Rampazzo, 2021/09/20
- [PATCH 6/6] avocado_qemu: fix inheritance order on LinuxTest class, Willian Rampazzo, 2021/09/20
- Re: [PATCH 0/6] avocado_qemu: small fixes and tweaks, Philippe Mathieu-Daudé, 2021/09/27
- Re: [PATCH 0/6] avocado_qemu: small fixes and tweaks, Philippe Mathieu-Daudé, 2021/09/27