Re: [PATCH 30/30] accel/tcg/user-exec: Implement CPU-specific signal handler for LoongArch hosts

[Richard Henderson]

On 9/20/21 1:04 AM, WANG Xuerui wrote:
> Signed-off-by: WANG Xuerui <git@xen0n.name>
> ---
>   accel/tcg/user-exec.c | 83 +++++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 83 insertions(+)
>
> diff --git a/accel/tcg/user-exec.c b/accel/tcg/user-exec.c
> index 8fed542622..0f85062e61 100644
> --- a/accel/tcg/user-exec.c
> +++ b/accel/tcg/user-exec.c
> @@ -878,6 +878,89 @@ int cpu_signal_handler(int host_signum, void *pinfo,
>       return handle_cpu_signal(pc, info, is_write, &uc->uc_sigmask);
>   }
>   
> +#elif defined(__loongarch__)
> +
> +/*
> + * This logic is bitness-agnostic, so the generic __loongarch__ guard is used
> + * instead of explicit ones like __loongarch64.
> + */
> +
> +int cpu_signal_handler(int host_signum, void *pinfo,
> +                       void *puc)

Looks ok, as far as it goes.  Similar comments about loongarch64 vs loongarch32 
vs loongarch.

Also have a look at

20210918184527.408540-1-richard.henderson@linaro.org/">https://lore.kernel.org/qemu-devel/20210918184527.408540-1-richard.henderson@linaro.org/


r~