Re: [RFC PATCH] tests/acpi/pcihp: add unit tests for hotplug on multifunction bridges for q35

[Ani Sinha]

On Sun, 19 Sep 2021, Ani Sinha wrote:


> > > > +static void test_acpi_q35_multif_bridge(void)
> > > > +{
> > > > +    test_data data = {
> > > > +        .machine = MACHINE_Q35,
> > > > +        .variant = ".multi-bridge",
> > >
> > > > +        .required_struct_types = base_required_struct_types,
> > > > +        .required_struct_types_len = 
> > > > ARRAY_SIZE(base_required_struct_types)
> > > do we care, i.e. why is this here?
> >
> > This verifies the smbios struct. It seems most of the other tests uses it.
> > So I left it in this test also.
> > Which of the tests should not be testing smbios?
>

> Right now smbios is only tested for non-uefi firmware. There are lots
> of tests that does not use uefi yet exercize the smbios struct tests.
> For example:
>
> test_acpi_piix4_tcg
> test_acpi_piix4_tcg_bridge
> test_acpi_piix4_no_root_hotplug
> test_acpi_piix4_no_bridge_hotplug
> test_acpi_piix4_no_acpi_pci_hotplug
> test_acpi_q35_tcg
> test_acpi_q35_tcg_bridge
> test_acpi_q35_tcg_mmio64
> test_acpi_q35_tcg_ipmi
> test_acpi_piix4_tcg_ipmi
>
> Should the smbios struct verification tests be removed from all of them?

To answer my own question ...

> test_acpi_q35_tcg

This uses smbios options directly. So we need to keep smbios specific
verifications.

> test_acpi_piix4_no_root_hotplug
> test_acpi_piix4_no_bridge_hotplug
> test_acpi_piix4_no_acpi_pci_hotplug

I think smbios specific struct tests can be removed from all of the above.
They just deal with DSDT tables.

Out of the rest,

> test_acpi_piix4_tcg
> test_acpi_piix4_tcg_bridge
> test_acpi_q35_tcg_bridge

I am not sure for the above three. I am not sure if the options passed
indirectly affect smbios. Probably not?

> test_acpi_q35_tcg_mmio64
> test_acpi_q35_tcg_ipmi
> test_acpi_piix4_tcg_ipmi

For the above three, we probably need the smbios checks. Again I am not
100% certain.