qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH-for-6.1] target/mips: Check nanoMIPS DSP MULT[U] accumulator


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH-for-6.1] target/mips: Check nanoMIPS DSP MULT[U] accumulator with Release 6
Date: Sat, 18 Sep 2021 11:29:36 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0

On 7/27/21 18:38, Richard Henderson wrote:
> On 7/26/21 10:30 PM, Philippe Mathieu-Daudé wrote:
>> Per the "MIPS Architecture Extension: nanoMIPS32 DSP TRM" rev 0.04,
>> MULT and MULTU opcodes:
>>
>>    The value of ac selects an accumulator numbered from 0 to 3.
>>    When ac=0, this refers to the original HI/LO register pair of the
>>    MIPS32 architecture.
>>
>>    In Release 6 of the MIPS Architecture, accumulators are eliminated
>>    from MIPS32.
>>
>> Ensure pre-Release 6 is restricted to HI/LO registers pair.
>>
>> Fixes: 8b3698b2947 ("target/mips: Add emulation of DSP ASE for
>> nanoMIPS - part 4")
>> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
>> ---
>>   target/mips/tcg/nanomips_translate.c.inc | 6 ++++++
>>   1 file changed, 6 insertions(+)
> 
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

Thanks, applied to mips-next.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]