[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 9/9] bsd-user: Apply 86abac06c14 from linux-user (target_mprotect
From: |
Warner Losh |
Subject: |
[PATCH 9/9] bsd-user: Apply 86abac06c14 from linux-user (target_mprotect can't fail) |
Date: |
Thu, 16 Sep 2021 20:56:35 -0600 |
From: Paolo Bonzini <pbonzini@redhat.com>
linux-user: assert that target_mprotect cannot fail
All error conditions that target_mprotect checks are also checked
by target_mmap. EACCESS cannot happen because we are just removing
PROT_WRITE. ENOMEM should not happen because we are modifying a
whole VMA (and we have bigger problems anyway if it happens).
Fixes a Coverity false positive, where Coverity complains about
target_mprotect's return value being passed to tb_invalidate_phys_range.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
Signed-off-by: Warner Losh <imp@bsdimp.com>
---
bsd-user/mmap.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/bsd-user/mmap.c b/bsd-user/mmap.c
index 792ff00548..4ddbd50b62 100644
--- a/bsd-user/mmap.c
+++ b/bsd-user/mmap.c
@@ -591,10 +591,7 @@ abi_long target_mmap(abi_ulong start, abi_ulong len, int
prot,
goto fail;
if (!(prot & PROT_WRITE)) {
ret = target_mprotect(start, len, prot);
- if (ret != 0) {
- start = ret;
- goto the_end;
- }
+ assert(ret == 0);
}
goto the_end;
}
--
2.32.0
- Re: [PATCH 1/9] bsd-user: Apply e6deac9cf99 from linux-user (zero anonymous memory), (continued)
- [PATCH 3/9] bsd-user: MAP_ symbols are defined, so no need for ifdefs, Warner Losh, 2021/09/16
- [PATCH 4/9] bsd-user: mmap return ENOMEM on overflow, Warner Losh, 2021/09/16
- [PATCH 5/9] bsd-user: mmap prefer MAP_ANON for BSD, Warner Losh, 2021/09/16
- [PATCH 6/9] bsd-user: mmap line wrap change, Warner Losh, 2021/09/16
- [PATCH 7/9] bsd-user: Don't try to mmap fd when it is -1 independently from MAP_ANONYMOUS flag, Warner Losh, 2021/09/16
- [PATCH 8/9] bsd-user: Implement MAP_EXCL, required by jemalloc in head, Warner Losh, 2021/09/16
- [PATCH 9/9] bsd-user: Apply 86abac06c14 from linux-user (target_mprotect can't fail),
Warner Losh <=