Re: [PATCH] Add qemu_vga.ndrv to build/pc-bios folder

[Peter Maydell]

On Wed, 15 Sept 2021 at 14:31, Laurent Vivier <laurent@vivier.eu> wrote:
>
> CC Mark
> CC qemu-devel
>
> Le 01/09/2021 à 14:16, John Arbuckle a écrit :
> > Currently the file qemu_vga.ndrv is not copied into the /build/pc-bios 
> > folder. This makes all video resolution choices disappear from a PowerPC 
> > Mac OS guest. This patch has the qemu_vga.ndrv file copied into the 
> > build/pc-bios folder giving users back their video resolution choices.
> >
> > Signed-off-by: John Arbuckle <programmingkidx@gmail.com>
> > ---
> >  configure | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/configure b/configure
> > index 9a79a004d7..281577e46f 100755
> > --- a/configure
> > +++ b/configure
> > @@ -5056,7 +5056,9 @@ for bios_file in \
> >      $source_path/pc-bios/openbios-* \
> >      $source_path/pc-bios/u-boot.* \
> >      $source_path/pc-bios/edk2-*.fd.bz2 \
> > -    $source_path/pc-bios/palcode-*
> > +    $source_path/pc-bios/palcode-* \
> > +    $source_path/pc-bios/qemu_vga.ndrv
> > +
> >  do
> >      LINKS="$LINKS pc-bios/$(basename $bios_file)"

The code change here is right, but Mark suggested a
commit message rewording:

https://patchew.org/QEMU/20210831165020.84855-1-programmingkidx@gmail.com/

With Mark's rewording, you can have a
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

-- PMM