[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 27/53] target/xtensa: convert to use format_state instead
From: |
Max Filippov |
Subject: |
Re: [PATCH v2 27/53] target/xtensa: convert to use format_state instead of dump_state |
Date: |
Wed, 15 Sep 2021 00:54:21 -0700 |
On Wed, Sep 15, 2021 at 12:32 AM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> On 9/14/21 4:20 PM, Daniel P. Berrangé wrote:
> > if ((flags & CPU_DUMP_FPU) &&
> > xtensa_option_enabled(env->config, XTENSA_OPTION_FP_COPROCESSOR)) {
> > - qemu_fprintf(f, "\n");
> > + g_string_append_printf(buf, "\n");
>
> g_string_append_c(); simpler to move it before this if() statement.
It adds spacing between optional blocks, why does it need to be moved out?
> > if ((flags & CPU_DUMP_FPU) &&
> > xtensa_option_enabled(env->config, XTENSA_OPTION_DFP_COPROCESSOR)
> > &&
> > !xtensa_option_enabled(env->config,
> > XTENSA_OPTION_DFPU_SINGLE_ONLY)) {
> > - qemu_fprintf(f, "\n");
> > + g_string_append_printf(buf, "\n");
>
> Ditto (move out).
Here as well.
--
Thanks.
-- Max
- Re: [PATCH v2 22/53] target/rx: convert to use format_state instead of dump_state, (continued)
- [PATCH v2 24/53] target/sh: convert to use format_state instead of dump_state, Daniel P . Berrangé, 2021/09/14
- [PATCH v2 23/53] target/s390x: convert to use format_state instead of dump_state, Daniel P . Berrangé, 2021/09/14
- [PATCH v2 25/53] target/sparc: convert to use format_state instead of dump_state, Daniel P . Berrangé, 2021/09/14
- [PATCH v2 26/53] target/tricore: convert to use format_state instead of dump_state, Daniel P . Berrangé, 2021/09/14
- [PATCH v2 27/53] target/xtensa: convert to use format_state instead of dump_state, Daniel P . Berrangé, 2021/09/14
- [PATCH v2 28/53] monitor: remove 'info ioapic' HMP command, Daniel P . Berrangé, 2021/09/14
- [PATCH v2 29/53] qapi: introduce x-query-registers QMP command, Daniel P . Berrangé, 2021/09/14
[PATCH v2 30/53] qapi: introduce x-query-roms QMP command, Daniel P . Berrangé, 2021/09/14