Re: [PATCH 01/22] qapi: Tidy up unusual line breaks

[Marc-André Lureau]

Hi

On Mon, Sep 13, 2021 at 5:55 PM Markus Armbruster <armbru@redhat.com> wrote:

Marc-André Lureau <marcandre.lureau@redhat.com> writes:

> Hi
>
> On Mon, Sep 13, 2021 at 4:39 PM Markus Armbruster <armbru@redhat.com> wrote:
>
>> Break lines between members instead of within members.
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>>
>
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> I wish we would just automated tools to format files. With that git 2.23
> feature, no more excuses :):
> https://www.moxio.com/blog/43/ignoring-bulk-change-commits-with-git-blame

Interesting.

Yeah, unfortunately you would have to add the commit rev after it's merged.

> Sadly, our mixed json/py format doesn't get parsed after "blake" reformats
> it (strings or trailing commas).

Naming QAPI schema files .json even though their contents isn't was a
mistake.

We discussed possible improvements in the thread below

    Message-ID: <87ime52wxd.fsf@dusky.pond.sub.org>
    https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08325.html

Too much to read, but there's a summary:

    Message-ID: <877dt5ofoi.fsf@dusky.pond.sub.org>
    https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg02553.html

The least invasive way to achieve formatting automation could be
switching from bastardized JSON to proper subset of Python.

ok

 

What's "blake"?

Sorry, don't know why I always remember "blake" when it is simply  "black" (https://github.com/psf/black)