Re: [PATCH v4 17/21] LoongArch Linux User Emulation

[Song Gao]

Hi Richard,

On 09/05/2021 06:04 PM, Richard Henderson wrote:
>> +struct sigframe {
>> +    uint32_t sf_ass[4];             /* argument save space for o32 */
> 
> Surely there is no "o32" for loongarch?
> 

Yes, qemu only support 64bit. but the kernel has 'o32'.  Should we have to be 
consistent with the kernel?

>> +    uint32_t sf_code[2];            /* signal trampoline */
> 
> Note that there are patches on-list for moving the signal trampoline off of 
> the stack.
> 
>> diff --git a/linux-user/loongarch64/termbits.h 
>> b/linux-user/loongarch64/termbits.h
>> new file mode 100644
>> index 0000000..33e74ed
>> --- /dev/null
>> +++ b/linux-user/loongarch64/termbits.h
>> @@ -0,0 +1,229 @@
>> +#ifndef LINUX_USER_LOONGARCH_TERMBITS_H
>> +#define LINUX_USER_LOONGARCH_TERMBITS_H
>> +
>> +#define TARGET_NCCS 19
> 
> Surely you should be using generic/termbits.h?
> OK.
> We will prefer not to merge a linux-user port that is not upstream, because 
> the ABI may change in between.  Can you provide a pointer to your kernel port 
> in the meantime?


Latest kernel: https://github.com/loongson/linux/tree/loongarch-next


Song Gao
Thanks.