[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 6/7] monitor: Fix coredump issue in non-x86 platform
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH 6/7] monitor: Fix coredump issue in non-x86 platform |
|
Date: |
Wed, 8 Sep 2021 10:54:06 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 08/09/21 10:19, Yang Zhong wrote:
+ if (sgx_enabled) {
+ MachineState *ms = MACHINE(qdev_get_machine());
+ X86MachineState *x86ms = X86_MACHINE(qdev_get_machine());
+
You can use object_dynamic_cast(ms, TYPE_PC_MACHINE), something like:
PCMachineState *pcms =
object_dynamic_cast(qdev_get_machine(), TYPE_PC_MACHINE);
X86MachineState *x86ms;
if (!pcms) {
return NULL;
}
x86ms = X86_MACHINE(pcms);
if (!x86ms->sgx_epc_list) {
return NULL;
}
info = g_new0(SGXInfo, 1);
...
return info;
Also please squash this patch directly into patch 3 that introduces
sgx_get_info.
Paolo
- Re: [PATCH 4/7] bitops: Support 32 and 64 bit mask macro, (continued)
[PATCH 7/7] pc: Cleanup the SGX definitions, Yang Zhong, 2021/09/08
[PATCH 6/7] monitor: Fix coredump issue in non-x86 platform, Yang Zhong, 2021/09/08