RE: [EXTERNAL] [PULL 08/15] whpx nvmm: Drop useless migrate_del_blocker()

[Sunil Muthuswamy]

> -----Original Message-----
> From: Markus Armbruster <armbru@redhat.com>
> Sent: Thursday, August 26, 2021 9:51 PM
> To: qemu-devel@nongnu.org
> Cc: peter.maydell@linaro.org; Sunil Muthuswamy <sunilmut@microsoft.com>; 
> Kamil Rytarowski <kamil@netbsd.org>; Reinoud Zandijk
> <reinoud@netbsd.org>; Reinoud Zandijk <reinoud@NetBSD.org>; Michael S . 
> Tsirkin <mst@redhat.com>
> Subject: [EXTERNAL] [PULL 08/15] whpx nvmm: Drop useless migrate_del_blocker()
> 
> There is nothing to delete after migrate_add_blocker() failed.  Trying
> anyway is safe, but useless.  Don't.
> 
> Cc: Sunil Muthuswamy <sunilmut@microsoft.com>
> Cc: Kamil Rytarowski <kamil@netbsd.org>
> Cc: Reinoud Zandijk <reinoud@netbsd.org>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> Message-Id: <20210720125408.387910-9-armbru@redhat.com>
> Reviewed-by: Reinoud Zandijk <reinoud@NetBSD.org>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  target/i386/nvmm/nvmm-all.c | 1 -
>  target/i386/whpx/whpx-all.c | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/target/i386/nvmm/nvmm-all.c b/target/i386/nvmm/nvmm-all.c
> index dfa690d65d..7bb0d9e30e 100644
> --- a/target/i386/nvmm/nvmm-all.c
> +++ b/target/i386/nvmm/nvmm-all.c
> @@ -929,7 +929,6 @@ nvmm_init_vcpu(CPUState *cpu)
>          (void)migrate_add_blocker(nvmm_migration_blocker, &local_error);
>          if (local_error) {
>              error_report_err(local_error);
> -            migrate_del_blocker(nvmm_migration_blocker);
>              error_free(nvmm_migration_blocker);
>              return -EINVAL;
>          }
> diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c
> index f832f286ac..cc8c0b984b 100644
> --- a/target/i386/whpx/whpx-all.c
> +++ b/target/i386/whpx/whpx-all.c
> @@ -1349,7 +1349,6 @@ int whpx_init_vcpu(CPUState *cpu)
>          (void)migrate_add_blocker(whpx_migration_blocker, &local_error);
>          if (local_error) {
>              error_report_err(local_error);
> -            migrate_del_blocker(whpx_migration_blocker);
>              error_free(whpx_migration_blocker);
>              ret = -EINVAL;
>              goto error;
> --
> 2.31.1

Signed-off-by: Sunil Muthuswamy <sunilmut@microsoft.com>