[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 30/43] bsd-user: Remove dead #ifdefs from elfload.c
|
From: |
Warner Losh |
|
Subject: |
Re: [PATCH v2 30/43] bsd-user: Remove dead #ifdefs from elfload.c |
|
Date: |
Fri, 27 Aug 2021 10:28:58 -0600 |
> On Aug 27, 2021, at 9:58 AM, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> On 8/27/21 5:02 PM, Warner Losh wrote:
>>> On Aug 26, 2021, at 10:42 PM, Philippe Mathieu-Daudé <f4bug@amsat.org>
>>> wrote:
>>>
>>> On 8/26/21 11:11 PM, imp@bsdimp.com wrote:
>>>> From: Warner Losh <imp@FreeBSD.org>
>>>>
>>>> LOW_ELF_STACK doesn't exist on FreeBSD and likely never will. Remove it.
>>>> Likewise, remove an #if 0 block that's not useful
>>>>
>>>> Signed-off-by: Warner Losh <imp@bsdimp.com>
>>>> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>>>> ---
>>>> bsd-user/elfload.c | 20 --------------------
>>>> 1 file changed, 20 deletions(-)
>>>
>>> Move as patch #14?
>>
>> Are you suggesting I move this to be right after patch #14 or that I squash
>> / fold it into patch #14?
>
> Move, if possible. If too much trouble (rebase conflict) then
> don't worry and let it here.
Yea, there’s rebase failures that aren’t trivial to resolve :( Too many moving
parts in this patch set.
>> Warner
>>
>>> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
signature.asc
Description: Message signed with OpenPGP
- [PATCH v2 39/43] bsd-user: move qemu_log to later in the file, (continued)
- [PATCH v2 39/43] bsd-user: move qemu_log to later in the file, imp, 2021/08/26
- [PATCH v2 29/43] bsd-user: elf cleanup, imp, 2021/08/26
- [PATCH v2 31/43] bsd-user: Rewrite target system call definintion glue, imp, 2021/08/26
- [PATCH v2 25/43] bsd-user: Add architecture specific signal tramp code, imp, 2021/08/26
- [PATCH v2 27/43] bsd-user: Move stack initializtion into a per-os file., imp, 2021/08/26
- [PATCH v2 34/43] bsd-user: Add target_arch_reg to describe a target's register set, imp, 2021/08/26
- [PATCH v2 30/43] bsd-user: Remove dead #ifdefs from elfload.c, imp, 2021/08/26
[PATCH v2 36/43] bsd-user: add stubbed out core dump support, imp, 2021/08/26
[PATCH v2 38/43] bsd-user: Refactor load_elf_sections and is_target_elf_binary, imp, 2021/08/26
[PATCH v2 42/43] bsd-user: Add '-0 argv0' option to bsd-user/main.c, imp, 2021/08/26
[PATCH v2 37/43] bsd-user: elfload.c style catch up patch, imp, 2021/08/26
[PATCH v2 41/43] bsd-user: Implement cpu_copy() helper routine, imp, 2021/08/26