[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] sun4m: fix setting CPU id when more than one CPU is present
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH] sun4m: fix setting CPU id when more than one CPU is present |
|
Date: |
Wed, 25 Aug 2021 15:59:53 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 8/25/21 2:27 PM, Mark Cave-Ayland wrote:
> On 25/08/2021 11:43, Philippe Mathieu-Daudé wrote:
>
>> +Leon3 maintainers
>
> Note that despite its presence in CPUSPARCState MXCC isn't part of the
> SPARC CPU but defined as part of the sun4m architecture, so I'm not sure
> it even exists in LEON3 (which is likely another reason it was written
> the way it was).
>
> Whilst there could potentially be some tidy-up in this area from people
> more knowledgeable about SPARC CPUs, the original patch seems the best
> approach to me since in the absence of experts in multi-CPU SPARC
> systems it simply restores the previous behaviour broken by the
> referenced Fixes: patch.
With that in mind:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
>> On Wed, Aug 25, 2021 at 12:39 PM Mark Cave-Ayland
>> <mark.cave-ayland@ilande.co.uk> wrote:
>>> On 25/08/2021 11:29, Philippe Mathieu-Daudé wrote:
>>>> On 8/25/21 11:51 AM, Mark Cave-Ayland wrote:
>>> Also MXCC is specific to 32-bit SPARC: maybe it was written this way
>>> to allow for
>>> future multi-CPU support for 64-bit SPARC?
>>
>> Will this happen?
>
> Hopefully one day, as my TODO list gradually gets whittled down...
What is your secret?