[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Bug 1926995] Re: hw/remote/mpqemu-link.c:221: bad error checking ?
From: |
Thomas Huth |
Subject: |
[Bug 1926995] Re: hw/remote/mpqemu-link.c:221: bad error checking ? |
Date: |
Wed, 25 Aug 2021 07:06:30 -0000 |
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1926995
Title:
hw/remote/mpqemu-link.c:221: bad error checking ?
Status in QEMU:
Fix Released
Bug description:
hw/remote/mpqemu-link.c:221:36: warning: logical ‘and’ of mutually
exclusive tests is always false [-Wlogical-op]
Source code is
if (msg->cmd >= MPQEMU_CMD_MAX && msg->cmd < 0) {
return false;
}
Maybe better code:
if (msg->cmd >= MPQEMU_CMD_MAX || msg->cmd < 0) {
return false;
}
It might be useful to switch on gcc compiler flag -Wlogical-op
to see these warnings.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1926995/+subscriptions
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Bug 1926995] Re: hw/remote/mpqemu-link.c:221: bad error checking ?,
Thomas Huth <=