[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v7 2/7] spapr.c: handle dev->id in spapr_memory_unplug_rollback()
From: |
Daniel Henrique Barboza |
Subject: |
[PATCH v7 2/7] spapr.c: handle dev->id in spapr_memory_unplug_rollback() |
Date: |
Tue, 24 Aug 2021 21:48:30 -0300 |
As done in hw/acpi/memory_hotplug.c, pass an empty string if dev->id
is NULL to qapi_event_send_mem_unplug_error() to avoid relying on
a behavior that can be changed in the future.
Suggested-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
---
hw/ppc/spapr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 81699d4f8b..4f1ee90e9e 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -3690,7 +3690,7 @@ void spapr_memory_unplug_rollback(SpaprMachineState
*spapr, DeviceState *dev)
*/
qapi_error = g_strdup_printf("Memory hotunplug rejected by the guest "
"for device %s", dev->id);
- qapi_event_send_mem_unplug_error(dev->id, qapi_error);
+ qapi_event_send_mem_unplug_error(dev->id ? : "", qapi_error);
}
/* Callback to be called during DRC release. */
--
2.31.1
- [PATCH v7 0/7] DEVICE_UNPLUG_GUEST_ERROR QAPI event, Daniel Henrique Barboza, 2021/08/24
- [PATCH v7 1/7] memory_hotplug.c: handle dev->id = NULL in acpi_memory_hotplug_write(), Daniel Henrique Barboza, 2021/08/24
- [PATCH v7 2/7] spapr.c: handle dev->id in spapr_memory_unplug_rollback(),
Daniel Henrique Barboza <=
- [PATCH v7 3/7] spapr_drc.c: do not error_report() when drc->dev->id == NULL, Daniel Henrique Barboza, 2021/08/24
- [PATCH v7 6/7] spapr: use DEVICE_UNPLUG_GUEST_ERROR to report unplug errors, Daniel Henrique Barboza, 2021/08/24
- [PATCH v7 5/7] qapi/qdev.json: add DEVICE_UNPLUG_GUEST_ERROR QAPI event, Daniel Henrique Barboza, 2021/08/24
- [PATCH v7 4/7] qapi/qdev.json: fix DEVICE_DELETED parameters doc, Daniel Henrique Barboza, 2021/08/24