Re: [PATCH v2 22/30] linux-user/mips: Improve do_break

[Philippe Mathieu-Daudé]

On 8/22/21 5:55 AM, Richard Henderson wrote:
> Rename to do_tr_or_bp, as per the kernel function.
> Add a 'trap' argument, akin to the kernel's si_code, but clearer.
> The return value is always 0, so change the return value to void.
> Use force_sig and force_sig_fault.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  linux-user/mips/cpu_loop.c | 47 ++++++++++++++++++++++----------------
>  1 file changed, 27 insertions(+), 20 deletions(-)

>      default:
> -        info->si_signo = TARGET_SIGTRAP;
> -        info->si_errno = 0;
> -        queue_signal(env, info->si_signo, QEMU_SI_FAULT, &*info);

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>