[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/acpi/pcihp: validate bsel property of the bus before unpl
|
From: |
Ani Sinha |
|
Subject: |
Re: [PATCH] hw/acpi/pcihp: validate bsel property of the bus before unplugging device |
|
Date: |
Tue, 24 Aug 2021 15:00:58 +0530 (IST) |
|
User-agent: |
Alpine 2.22 (DEB 394 2020-01-19) |
On Tue, 24 Aug 2021, Igor Mammedov wrote:
> On Mon, 23 Aug 2021 19:06:47 -0400
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
> > On Sat, Aug 21, 2021 at 08:35:35PM +0530, Ani Sinha wrote:
> > > Bsel property of the pci bus indicates whether the bus supports acpi
> > > hotplug.
> > > We need to validate the presence of this property before performing any
> > > hotplug
> > > related callback operations. Currently validation of the existence of this
> > > property was absent from acpi_pcihp_device_unplug_cb() function but is
> > > present
> > > in other hotplug/unplug callback functions. Hence, this change adds the
> > > missing
> > > check for the above function.
> > >
> > > Signed-off-by: Ani Sinha <ani@anisinha.ca>
> >
> > I queued this but I have a general question:
> I convinced myself that this patch is wrong, pls drop it.
OK so now we have a situation where this function callback does not have
this check whereas others does. Should we drop them from everywhere?