[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v8 13/34] block/copy-before-write: bdrv_cbw_append(): replace chi
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[PATCH v8 13/34] block/copy-before-write: bdrv_cbw_append(): replace child at last |
Date: |
Tue, 24 Aug 2021 11:38:35 +0300 |
Refactor the function to replace child at last. Thus we don't need to
revert it and code is simplified.
block-copy state initialization being done before replacing the child
doesn't need any drained section.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
---
block/copy-before-write.c | 33 +++++++++++----------------------
1 file changed, 11 insertions(+), 22 deletions(-)
diff --git a/block/copy-before-write.c b/block/copy-before-write.c
index 7a6c15f141..adbbc64aa9 100644
--- a/block/copy-before-write.c
+++ b/block/copy-before-write.c
@@ -172,7 +172,6 @@ BlockDriverState *bdrv_cbw_append(BlockDriverState *source,
int ret;
BDRVCopyBeforeWriteState *state;
BlockDriverState *top;
- bool appended = false;
assert(source->total_sectors == target->total_sectors);
@@ -196,8 +195,7 @@ BlockDriverState *bdrv_cbw_append(BlockDriverState *source,
BDRV_CHILD_DATA, errp);
if (!state->target) {
error_prepend(errp, "Cannot attach target child: ");
- bdrv_unref(top);
- return NULL;
+ goto fail;
}
bdrv_ref(source);
@@ -206,18 +204,8 @@ BlockDriverState *bdrv_cbw_append(BlockDriverState *source,
errp);
if (!top->file) {
error_prepend(errp, "Cannot attach file child: ");
- bdrv_unref(top);
- return NULL;
- }
-
- bdrv_drained_begin(source);
-
- ret = bdrv_replace_node(source, top, errp);
- if (ret < 0) {
- error_prepend(errp, "Cannot append copy-before-write filter: ");
goto fail;
}
- appended = true;
state->bcs = block_copy_state_new(top->file, state->target, false,
compress,
errp);
@@ -225,21 +213,22 @@ BlockDriverState *bdrv_cbw_append(BlockDriverState
*source,
error_prepend(errp, "Cannot create block-copy-state: ");
goto fail;
}
- *bcs = state->bcs;
+ bdrv_drained_begin(source);
+ ret = bdrv_replace_node(source, top, errp);
bdrv_drained_end(source);
+ if (ret < 0) {
+ error_prepend(errp, "Cannot append copy-before-write filter: ");
+ goto fail;
+ }
+
+ *bcs = state->bcs;
return top;
fail:
- if (appended) {
- bdrv_cbw_drop(top);
- } else {
- bdrv_unref(top);
- }
-
- bdrv_drained_end(source);
-
+ block_copy_state_free(state->bcs);
+ bdrv_unref(top);
return NULL;
}
--
2.29.2
- [PATCH v8 11/34] block/copy-before-write: drop extra bdrv_unref on failure path, (continued)
- [PATCH v8 11/34] block/copy-before-write: drop extra bdrv_unref on failure path, Vladimir Sementsov-Ogievskiy, 2021/08/24
- [PATCH v8 16/34] block/copy-before-write: cbw_init(): use file child after attaching, Vladimir Sementsov-Ogievskiy, 2021/08/24
- [PATCH v8 10/34] block/copy-before-write: relax permission requirements when no parents, Vladimir Sementsov-Ogievskiy, 2021/08/24
- [PATCH v8 18/34] block/copy-before-write: cbw_init(): use options, Vladimir Sementsov-Ogievskiy, 2021/08/24
- [PATCH v8 12/34] block/copy-before-write: use file child instead of backing, Vladimir Sementsov-Ogievskiy, 2021/08/24
- [PATCH v8 09/34] block/backup: move cluster size calculation to block-copy, Vladimir Sementsov-Ogievskiy, 2021/08/24
- [PATCH v8 15/34] block/copy-before-write: cbw_init(): rename variables, Vladimir Sementsov-Ogievskiy, 2021/08/24
- [PATCH v8 25/34] python:QEMUMachine: template typing for self returning methods, Vladimir Sementsov-Ogievskiy, 2021/08/24
- [PATCH v8 22/34] qapi: publish copy-before-write filter, Vladimir Sementsov-Ogievskiy, 2021/08/24
- [PATCH v8 26/34] iotests/222: fix pylint and mypy complains, Vladimir Sementsov-Ogievskiy, 2021/08/24
- [PATCH v8 13/34] block/copy-before-write: bdrv_cbw_append(): replace child at last,
Vladimir Sementsov-Ogievskiy <=
- [PATCH v8 21/34] block/copy-before-write: make public block driver, Vladimir Sementsov-Ogievskiy, 2021/08/24
- [PATCH v8 17/34] block/copy-before-write: bdrv_cbw_append(): drop unused compress arg, Vladimir Sementsov-Ogievskiy, 2021/08/24
- [PATCH v8 19/34] block/copy-before-write: initialize block-copy bitmap, Vladimir Sementsov-Ogievskiy, 2021/08/24
- [PATCH v8 20/34] block/block-copy: make setting progress optional, Vladimir Sementsov-Ogievskiy, 2021/08/24
- [PATCH v8 23/34] python/qemu/machine.py: refactor _qemu_args(), Vladimir Sementsov-Ogievskiy, 2021/08/24
- [PATCH v8 24/34] python/qemu/machine: QEMUMachine: improve qmp() method, Vladimir Sementsov-Ogievskiy, 2021/08/24
- [PATCH v8 28/34] iotests: move 222 to tests/image-fleecing, Vladimir Sementsov-Ogievskiy, 2021/08/24
- [PATCH v8 27/34] iotests/222: constantly use single quotes for strings, Vladimir Sementsov-Ogievskiy, 2021/08/24
- [PATCH v8 29/34] iotests.py: hmp_qemu_io: support qdev, Vladimir Sementsov-Ogievskiy, 2021/08/24
- [PATCH v8 30/34] iotests/image-fleecing: proper source device, Vladimir Sementsov-Ogievskiy, 2021/08/24