[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v8 11/34] block/copy-before-write: drop extra bdrv_unref on failu
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[PATCH v8 11/34] block/copy-before-write: drop extra bdrv_unref on failure path |
Date: |
Tue, 24 Aug 2021 11:38:33 +0300 |
bdrv_attach_child() do bdrv_unref() on failure, so we shouldn't do it
by hand here.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
---
block/copy-before-write.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/block/copy-before-write.c b/block/copy-before-write.c
index 2a51cc64e4..945d9340f4 100644
--- a/block/copy-before-write.c
+++ b/block/copy-before-write.c
@@ -201,7 +201,6 @@ BlockDriverState *bdrv_cbw_append(BlockDriverState *source,
state->target = bdrv_attach_child(top, target, "target", &child_of_bds,
BDRV_CHILD_DATA, errp);
if (!state->target) {
- bdrv_unref(target);
bdrv_unref(top);
return NULL;
}
--
2.29.2
- [PATCH v8 01/34] block: introduce bdrv_replace_child_bs(), (continued)
- [PATCH v8 01/34] block: introduce bdrv_replace_child_bs(), Vladimir Sementsov-Ogievskiy, 2021/08/24
- [PATCH v8 06/34] block-copy: move detecting fleecing scheme to block-copy, Vladimir Sementsov-Ogievskiy, 2021/08/24
- [PATCH v8 08/34] block/backup: set copy_range and compress after filter insertion, Vladimir Sementsov-Ogievskiy, 2021/08/24
- [PATCH v8 03/34] qdev-properties: PropertyInfo: add realized_set_allowed field, Vladimir Sementsov-Ogievskiy, 2021/08/24
- [PATCH v8 04/34] qdev: allow setting drive property for realized device, Vladimir Sementsov-Ogievskiy, 2021/08/24
- [PATCH v8 07/34] block/block-copy: introduce block_copy_set_copy_opts(), Vladimir Sementsov-Ogievskiy, 2021/08/24
- [PATCH v8 02/34] block: introduce blk_replace_bs, Vladimir Sementsov-Ogievskiy, 2021/08/24
- [PATCH v8 05/34] block: rename backup-top to copy-before-write, Vladimir Sementsov-Ogievskiy, 2021/08/24
- [PATCH v8 14/34] block/copy-before-write: introduce cbw_init(), Vladimir Sementsov-Ogievskiy, 2021/08/24
- [PATCH v8 11/34] block/copy-before-write: drop extra bdrv_unref on failure path,
Vladimir Sementsov-Ogievskiy <=
- [PATCH v8 16/34] block/copy-before-write: cbw_init(): use file child after attaching, Vladimir Sementsov-Ogievskiy, 2021/08/24
- [PATCH v8 10/34] block/copy-before-write: relax permission requirements when no parents, Vladimir Sementsov-Ogievskiy, 2021/08/24
- [PATCH v8 18/34] block/copy-before-write: cbw_init(): use options, Vladimir Sementsov-Ogievskiy, 2021/08/24
- [PATCH v8 12/34] block/copy-before-write: use file child instead of backing, Vladimir Sementsov-Ogievskiy, 2021/08/24
- [PATCH v8 09/34] block/backup: move cluster size calculation to block-copy, Vladimir Sementsov-Ogievskiy, 2021/08/24
- [PATCH v8 15/34] block/copy-before-write: cbw_init(): rename variables, Vladimir Sementsov-Ogievskiy, 2021/08/24
- [PATCH v8 25/34] python:QEMUMachine: template typing for self returning methods, Vladimir Sementsov-Ogievskiy, 2021/08/24
- [PATCH v8 22/34] qapi: publish copy-before-write filter, Vladimir Sementsov-Ogievskiy, 2021/08/24
- [PATCH v8 26/34] iotests/222: fix pylint and mypy complains, Vladimir Sementsov-Ogievskiy, 2021/08/24