Re: [PATCH v3 63/66] tcg/tci: Support raising sigbus for user-only

[Richard Henderson]

On 8/22/21 5:32 AM, Peter Maydell wrote:
> On Sun, 22 Aug 2021 at 08:59, Richard Henderson
> <richard.henderson@linaro.org> wrote:
> > On 8/20/21 3:14 AM, Peter Maydell wrote:
> > > > @@ -377,11 +381,11 @@ static uint64_t tci_qemu_ld(CPUArchState *env, 
> > > > target_ulong taddr,
> > > >    static void tci_qemu_st(CPUArchState *env, target_ulong taddr, uint64_t val,
> > > >                            MemOpIdx oi, const void *tb_ptr)
> > > >    {
> > > > -    MemOp mop = get_memop(oi) & (MO_BSWAP | MO_SSIZE);
> > > > +    MemOp mop = get_memop(oi);
> > > >        uintptr_t ra = (uintptr_t)tb_ptr;
> > >
> > > Don't you need this bit in tci_qemu_st() as well ?
> >
> > Which bit isn't present in st as well?
> > There's missing hunks in your reply, but afaics they're the same.
>
> 20210818191920.390759-1-richard.henderson@linaro.org/20210818191920.390759-64-richard.henderson@linaro.org/">https://patchew.org/QEMU/20210818191920.390759-1-richard.henderson@linaro.org/20210818191920.390759-64-richard.henderson@linaro.org/
>
> I had the function name wrong, but only the tci_qemu_st() change
> has this bit:
>
> -    MemOp mop = get_memop(oi) & (MO_BSWAP | MO_SSIZE);
> +    MemOp mop = get_memop(oi);

Ah yes, thanks.

r~