Re: [PATCH] memory: Have 'info mtree' remove duplicated Address Space information

[Peter Xu]

Phil,

On Fri, Aug 20, 2021 at 12:58:05PM +0200, Philippe Mathieu-Daudé wrote:
> >   (qemu) info mtree
> >   address-space: I/O
> >     0000000000000000-000000000000ffff (prio 0, i/o): io
> > 
> >   address-space shared 9 times:
> >     - cpu-memory-0
> >     - cpu-memory-1
> >     - cpu-memory-2
> >     - cpu-memory-3
> >     - cpu-secure-memory-0
> >     - cpu-secure-memory-1
> >     - cpu-secure-memory-2
> >     - cpu-secure-memory-3
> >     - memory

Do you think below would look better?

   address-space cpu-memory-0:
   address-space cpu-memory-1:
   address-space cpu-memory-3:
   ...
   address-space memory:
     [memory ranges]

"info mtree -f" has something similar:

FlatView #2
 AS "ich9-ahci", root: bus master container
 AS "vtd-root", root: vtd-00.0
 AS "virtio-blk-pci", root: bus master container
 AS "vtd-root", root: vtd-01.0
 AS "vtd-root", root: vtd-02.0
 AS "vtd-root", root: vtd-03.0
 AS "vtd-root", root: vtd-04.0
 AS "vtd-root", root: vtd-1f.0
 AS "vtd-root", root: vtd-1f.2
 AS "vtd-root", root: vtd-1f.3
 Root memory region: vtd-nodmar
   [memory ranges]

[...]

> > +struct AddressSpaceInfo {
> > +    MemoryRegionListHead *ml_head;
> > +    int counter;
> 
> Doh this field is unused :/

Looks good to me otherwise.

Thanks,

-- 
Peter Xu