RE: [PATCH] hw/arm/smmuv3: Support non-PCI/PCIe devices connection

[Li, Chunming]

> On Fri, 20 Aug 2021 at 03:36, Li, Chunming
> <Chunming.Li@verisilicon.com> wrote:
> >
> > The current SMMU V3 device model only support PCI/PCIe devices,
> > so we update it to support non-PCI/PCIe devices.
> >
> >     hw/arm/smmuv3:
> >         . Create IOMMU memory regions for non-PCI/PCIe devices based
> on their SID
> >         . Add sid-map property to store non-PCI/PCIe devices SID
> >         . Update implementation of CFGI commands based on device SID
> >     hw/arm/smmu-common:
> >         . Differentiate PCI/PCIe and non-PCI/PCIe devices SID getting
> strategy
> >     hw/arm/virt:
> >         . Add PL330 DMA controller and connect with SMMUv3 for
> testing
> >         . Add smmuv3_sidmap for non-PCI/PCIe devices SID setting
> 
> Please don't try to do all these things in one big patch --
> put together a patchseries with several smaller patches,
> each of which does one self-contained thing.
> 
  Got it. Thanks for your comments.
  Let me try to split them into several smaller patches.
  But all these updates work for 1 thing. They are depend on each other.
> 
> > Signed-off-by: Chunming Li <chunming.li@verisilicon.com>
> > Signed-off-by: Renwei Liu <renwei.liu@verisilicon.com>
> > ---
> > This patch depends on PL330 memory region connection patch:
> >
> https://patchew.org/QEMU/4C23C17B8E87E74E906A25A3254A03F4FA1FEC31@SHASX
> M03.verisilicon.com/
> 
> If you have a patch that depends on another, it's usually better to
> send them as a patchseries. I was wondering what the reason for
> that PL330 patch was...
  I need a non-PCI/PCIe device to do the verification. The old PL330 DMA 
controller
  cannot configure its memory region manually. So we update it and provide path.
  PL330 patch was reviewed and will be merged in target-arm.next for 6.2.
  The virt.c compile will fail if there is no PL330 device patch.
> 
> thanks
> -- PMM

Thanks.

Chunming Li