[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/7] hw/adc: Make adci[*] R/W in NPCM7XX ADC
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 4/7] hw/adc: Make adci[*] R/W in NPCM7XX ADC |
Date: |
Fri, 20 Aug 2021 09:28:38 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 8/14/21 1:33 AM, Hao Wu wrote:
> Our sensor test requires both reading and writing from a sensor's
> QOM property. So we need to make the input of ADC module R/W instead
> of read only for that to work.
>
> Signed-off-by: Hao Wu <wuhaotsh@google.com>
> Reviewed-by: Titus Rwantare <titusr@google.com>
> ---
> hw/adc/npcm7xx_adc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/adc/npcm7xx_adc.c b/hw/adc/npcm7xx_adc.c
> index 47fb9e5f74..bc6f3f55e6 100644
> --- a/hw/adc/npcm7xx_adc.c
> +++ b/hw/adc/npcm7xx_adc.c
> @@ -242,7 +242,7 @@ static void npcm7xx_adc_init(Object *obj)
>
> for (i = 0; i < NPCM7XX_ADC_NUM_INPUTS; ++i) {
> object_property_add_uint32_ptr(obj, "adci[*]",
> - &s->adci[i], OBJ_PROP_FLAG_WRITE);
> + &s->adci[i], OBJ_PROP_FLAG_READWRITE);
What about:
qtest_enabled() ? OBJ_PROP_FLAG_READWRITE : OBJ_PROP_FLAG_WRITE
> }
> object_property_add_uint32_ptr(obj, "vref",
> &s->vref, OBJ_PROP_FLAG_WRITE);
>
- [PATCH 0/7] Misc NPCM7XX patches, Hao Wu, 2021/08/13
- [PATCH 1/7] hw/i2c: Clear ACK bit in NPCM7xx SMBus module, Hao Wu, 2021/08/13
- [PATCH 2/7] hw/i2c: Read FIFO during RXF_CTL change in NPCM7XX SMBus, Hao Wu, 2021/08/13
- [PATCH 3/7] hw/adc: Fix CONV bit in NPCM7XX ADC CON register, Hao Wu, 2021/08/13
- [PATCH 4/7] hw/adc: Make adci[*] R/W in NPCM7XX ADC, Hao Wu, 2021/08/13
- Re: [PATCH 4/7] hw/adc: Make adci[*] R/W in NPCM7XX ADC,
Philippe Mathieu-Daudé <=
- [PATCH 5/7] hw/nvram: Add a new auxiliary function to init at24c eeprom, Hao Wu, 2021/08/13
- [PATCH 6/7] hw/arm: quanta-gbs-bmc add i2c devices, Hao Wu, 2021/08/13
- [PATCH 7/7] hw/arm: Use unit number in quanta-gsj eeprom files, Hao Wu, 2021/08/13
- Re: [PATCH 0/7] Misc NPCM7XX patches, Peter Maydell, 2021/08/19