[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 6/6] memory: Have address_space_create() re-use global &a
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [RFC PATCH 6/6] memory: Have address_space_create() re-use global &address_space_memory |
|
Date: |
Fri, 20 Aug 2021 09:17:22 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 8/20/21 8:07 AM, Gerd Hoffmann wrote:
> Hi,
>
>> This also seems to me to be the tail wagging the dog. If we think
>> 'info mtree' has too much duplicate information (which it certainly
>> does) then we should make mtree_info() smarter about reducing that
>> duplication. Off the top of my head, we could change the code that
>> prints ASes to do something like:
>
>> qemu_printf("...same as address-space %s\n", name);
>
> Neat idea.
>
> Having 'info mtree' accept an (optional) 'name' parameter to pick an
> address space to be printed would be useful too.
Yeah, for now I am thinking of a match string (for my use cases):
(qemu) info mtree -a dma # all address spaces matching *dma*
- [PATCH 4/6] hw/dma: Replace alloc() + address_space_init() by address_space_create(), (continued)
[PATCH 5/6] hw/usb: Replace alloc() + address_space_init() by address_space_create(), Philippe Mathieu-Daudé, 2021/08/19
[RFC PATCH 6/6] memory: Have address_space_create() re-use global &address_space_memory, Philippe Mathieu-Daudé, 2021/08/19