[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 15/66] target/sh4: Implement do_unaligned_access for user-
From: |
Peter Maydell |
Subject: |
Re: [PATCH v3 15/66] target/sh4: Implement do_unaligned_access for user-only |
Date: |
Thu, 19 Aug 2021 16:46:28 +0100 |
On Wed, 18 Aug 2021 at 20:26, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> linux-user/sh4/cpu_loop.c | 8 ++++++++
> target/sh4/cpu.c | 2 +-
> target/sh4/op_helper.c | 3 ---
> 3 files changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/linux-user/sh4/cpu_loop.c b/linux-user/sh4/cpu_loop.c
> index 222ed1c670..21d97250a8 100644
> --- a/linux-user/sh4/cpu_loop.c
> +++ b/linux-user/sh4/cpu_loop.c
> @@ -71,6 +71,14 @@ void cpu_loop(CPUSH4State *env)
> info._sifields._sigfault._addr = env->tea;
> queue_signal(env, info.si_signo, QEMU_SI_FAULT, &info);
> break;
> + case 0xe0:
> + case 0x100:
> + info.si_signo = TARGET_SIGBUS;
> + info.si_errno = 0;
> + info.si_code = TARGET_BUS_ADRALN;
> + info._sifields._sigfault._addr = env->tea;
> + queue_signal(env, info.si_signo, QEMU_SI_FAULT, &info);
> + break;
> case EXCP_ATOMIC:
> cpu_exec_step_atomic(cs);
> arch_interrupt = false;
Doesn't this have to wait until after the later patches in the
series that implement the "actually don't worry about alignment
on most sh4 load/stores" ?
-- PMM
- Re: [PATCH v3 11/66] target/ppc: Implement do_unaligned_access for user-only, (continued)
- [PATCH v3 07/66] target/microblaze: Do not set MO_ALIGN for user-only, Richard Henderson, 2021/08/18
- [PATCH v3 12/66] target/riscv: Implement do_unaligned_access for user-only, Richard Henderson, 2021/08/18
- [PATCH v3 14/66] target/sh4: Set fault address in superh_cpu_do_unaligned_access, Richard Henderson, 2021/08/18
- [PATCH v3 16/66] target/sparc: Remove DEBUG_UNALIGNED, Richard Henderson, 2021/08/18
- [PATCH v3 18/66] target/sparc: Set fault address in sparc_cpu_do_unaligned_access, Richard Henderson, 2021/08/18
- [PATCH v3 13/66] target/s390x: Implement do_unaligned_access for user-only, Richard Henderson, 2021/08/18
- [PATCH v3 08/66] target/mips: Implement do_unaligned_access for user-only, Richard Henderson, 2021/08/18
- [PATCH v3 15/66] target/sh4: Implement do_unaligned_access for user-only, Richard Henderson, 2021/08/18
- Re: [PATCH v3 15/66] target/sh4: Implement do_unaligned_access for user-only,
Peter Maydell <=
- [PATCH v3 17/66] target/sparc: Split out build_sfsr, Richard Henderson, 2021/08/18
- [PATCH v3 20/66] target/xtensa: Implement do_unaligned_access for user-only, Richard Henderson, 2021/08/18
- [PATCH v3 22/66] accel/tcg: Drop signness in tracing in cputlb.c, Richard Henderson, 2021/08/18
- [PATCH v3 19/66] target/sparc: Implement do_unaligned_access for user-only, Richard Henderson, 2021/08/18
- [PATCH v3 21/66] accel/tcg: Report unaligned atomics for user-only, Richard Henderson, 2021/08/18
- [PATCH v3 25/66] tcg: Split out MemOpIdx to exec/memopidx.h, Richard Henderson, 2021/08/18
- [PATCH v3 27/66] accel/tcg: Pass MemOpIdx to atomic_trace_*_post, Richard Henderson, 2021/08/18
- [PATCH v3 29/66] trace: Split guest_mem_before, Richard Henderson, 2021/08/18