[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/5] target/mips: Replace GET_LMASK() macro by get_lmask(32)
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH 2/5] target/mips: Replace GET_LMASK() macro by get_lmask(32) function |
|
Date: |
Wed, 18 Aug 2021 23:30:40 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 8/18/21 7:09 PM, Richard Henderson wrote:
> On 8/18/21 6:43 AM, Philippe Mathieu-Daudé wrote:
>> - if (GET_LMASK(arg2) <= 2) {
>> + if (get_lmask(env, arg2, 32) <= 2) {
>
> Whatever you decide to do with respect to the previous patch, the result
> of get_lmask is constant across the function and should be computed only
> once.
Oops I missed that, thanks.
- [PATCH 0/5] target/mips: Replace TARGET_WORDS_BIGENDIAN by cpu_is_bigendian(), Philippe Mathieu-Daudé, 2021/08/18
- [PATCH 1/5] target/mips: Replace GET_OFFSET() macro by get_offset() function, Philippe Mathieu-Daudé, 2021/08/18
- [PATCH 2/5] target/mips: Replace GET_LMASK() macro by get_lmask(32) function, Philippe Mathieu-Daudé, 2021/08/18
- [PATCH 3/5] target/mips: Replace GET_LMASK64() macro by get_lmask(64) function, Philippe Mathieu-Daudé, 2021/08/18
- [PATCH 4/5] target/mips: Store CP0_Config0 in DisasContext, Philippe Mathieu-Daudé, 2021/08/18
- [PATCH 5/5] target/mips: Replace TARGET_WORDS_BIGENDIAN by cpu_is_bigendian(), Philippe Mathieu-Daudé, 2021/08/18