[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 4/7] tcg/sparc: Improve code gen for shifted 32-bit constants
From: |
Richard Henderson |
Subject: |
[PATCH v3 4/7] tcg/sparc: Improve code gen for shifted 32-bit constants |
Date: |
Wed, 18 Aug 2021 10:45:59 -1000 |
We had code for checking for 13 and 21-bit shifted constants,
but we can do better and allow 32-bit shifted constants.
This is still 2 insns shorter than the full 64-bit sequence.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
tcg/sparc/tcg-target.c.inc | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/tcg/sparc/tcg-target.c.inc b/tcg/sparc/tcg-target.c.inc
index f11f054df5..16e2258b9b 100644
--- a/tcg/sparc/tcg-target.c.inc
+++ b/tcg/sparc/tcg-target.c.inc
@@ -456,17 +456,17 @@ static void tcg_out_movi_int(TCGContext *s, TCGType type,
TCGReg ret,
return;
}
- /* A 21-bit constant, shifted. */
+ /* A 32-bit constant, shifted. */
lsb = ctz64(arg);
test = (tcg_target_long)arg >> lsb;
- if (check_fit_tl(test, 13)) {
- tcg_out_movi_imm13(s, ret, test);
- tcg_out_arithi(s, ret, ret, lsb, SHIFT_SLLX);
- return;
- } else if (lsb > 10 && test == extract64(test, 0, 21)) {
+ if (lsb > 10 && test == extract64(test, 0, 21)) {
tcg_out_sethi(s, ret, test << 10);
tcg_out_arithi(s, ret, ret, lsb - 10, SHIFT_SLLX);
return;
+ } else if (test == (uint32_t)test || test == (int32_t)test) {
+ tcg_out_movi_int(s, TCG_TYPE_I64, ret, test, in_prologue, scratch);
+ tcg_out_arithi(s, ret, ret, lsb, SHIFT_SLLX);
+ return;
}
/* A 64-bit constant decomposed into 2 32-bit pieces. */
--
2.25.1
- [PATCH v3 0/7] tcg/sparc: Unaligned access and other cleanup, Richard Henderson, 2021/08/18
- [PATCH v3 1/7] tcg/sparc: Drop inline markers, Richard Henderson, 2021/08/18
- [PATCH v3 3/7] tcg/sparc: Add scratch argument to tcg_out_movi_int, Richard Henderson, 2021/08/18
- [PATCH v3 4/7] tcg/sparc: Improve code gen for shifted 32-bit constants,
Richard Henderson <=
- [PATCH v3 5/7] tcg/sparc: Use the constant pool for 64-bit constants, Richard Henderson, 2021/08/18
- [PATCH v3 2/7] tcg/sparc: Introduce tcg_out_mov_delay, Richard Henderson, 2021/08/18
- [PATCH v3 6/7] tcg/sparc: Add tcg_out_jmpl_const for better tail calls, Richard Henderson, 2021/08/18
- [PATCH v3 7/7] tcg/sparc: Support unaligned access for user-only, Richard Henderson, 2021/08/18