[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] block/file-win32: add reopen handlers
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v3] block/file-win32: add reopen handlers |
|
Date: |
Wed, 18 Aug 2021 00:29:03 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 8/17/21 10:21 PM, Viktor Prutyanov wrote:
> Make 'qemu-img commit' work on Windows.
>
> Command 'commit' requires reopening backing file in RW mode. So,
> add reopen prepare/commit/abort handlers and change dwShareMode
> for CreateFile call in order to allow further read/write reopening.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/418
> Suggested-by: Hanna Reitz <hreitz@redhat.com>
> Signed-off-by: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
> ---
> v2:
> - fix indentation in raw_reopen_prepare
> - free rs if raw_reopen_prepare fails
> v3:
> - restore suggested-by field missed in v2
>
> block/file-win32.c | 90 +++++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 89 insertions(+), 1 deletion(-)
LGTM, asked Helge Konetzka for testing (on the gitlab issue).
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>