[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] qapi/machine.json: Remove zero value reference from SMPConfi
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH] qapi/machine.json: Remove zero value reference from SMPConfiguration documentation |
|
Date: |
Tue, 17 Aug 2021 15:50:00 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 8/17/21 2:53 PM, Andrew Jones wrote:
> Commit 1e63fe685804 ("machine: pass QAPI struct to mc->smp_parse")
> introduced documentation stating that a zero input value for an SMP
> parameter indicates that its value should be automatically configured.
> This is indeed how things work today, but we'd like to change that.
> Avoid documenting behaviors we want to leave undefined for the time
> being, giving us freedom to change it later.
>
> Fixes: 1e63fe685804 ("machine: pass QAPI struct to mc->smp_parse")
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
> qapi/machine.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qapi/machine.json b/qapi/machine.json
> index c3210ee1fb24..157712f00614 100644
> --- a/qapi/machine.json
> +++ b/qapi/machine.json
> @@ -1288,7 +1288,7 @@
> ##
> # @SMPConfiguration:
> #
> -# Schema for CPU topology configuration. "0" or a missing value lets
> +# Schema for CPU topology configuration. A missing value lets
> # QEMU figure out a suitable value based on the ones that are provided.
> #
> # @cpus: number of virtual CPUs in the virtual machine
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>