[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Picture missing in About dialog on cocoa ui
From: |
Peter Maydell |
Subject: |
Re: Picture missing in About dialog on cocoa ui |
Date: |
Tue, 17 Aug 2021 09:59:06 +0100 |
On Mon, 16 Aug 2021 at 21:55, Programmingkid <programmingkidx@gmail.com> wrote:
>
>
>
> > On Jul 8, 2021, at 2:38 PM, Programmingkid <programmingkidx@gmail.com>
> > wrote:
> >
> >
> >
> >> On Jul 8, 2021, at 1:50 PM, Peter Maydell <peter.maydell@linaro.org> wrote:
> >>
> >> On Thu, 8 Jul 2021 at 17:28, Programmingkid <programmingkidx@gmail.com>
> >> wrote:
> >>> The problem with e31746ecf8dd2f25f687c94ac14016a3ba5debfc is it requires a
> >>> picture file to be found in a certain path. My original code used QEMU's
> >>> icon to obtain a picture. The reason why the picture in the About dialog
> >>> stopped appearing was because of the move to the meson build system.
> >>> A new patch has just been committed that fixes the missing icon issue.
> >>> Using 'git revert e31746ecf8dd2f25f687c94ac14016a3ba5debfc' fixes the
> >>> missing picture issue in the About dialog.
>
>
> Hi Peter, I was wondering if you had made a decision on whether you plan on
> reverting the patch that breaks the About dialog for the Cocoa UI.
No, reverting looks like the wrong thing. If get_relocated_path()
doesn't work then we should find and fix that bug.
-- PMM