Re: [PATCH v2] hw/i386/acpi-build: Get NUMA information from struct NumaState

[Liu, Jingqi]

On 8/16/2021 6:05 PM, Philippe Mathieu-Daudé wrote:
> On 8/6/21 5:19 AM, Jingqi Liu wrote:
>
> Maybe prepend with:
>
> Since commits aa57020774b ("numa: move numa global variable
> nb_numa_nodes into MachineState") and 7e721e7b10e ("numa: move
> numa global variable numa_info into MachineState"), we can ...
Seems this description is clearer.
I'll add it in next version.

Thanks,
Jingqi
> > We can get NUMA information completely from MachineState::numa_state.
> > Remove PCMachineState::numa_nodes and PCMachineState::node_mem,
> > since they are just copied from MachineState::numa_state.
> >
> > Signed-off-by: Jingqi Liu <jingqi.liu@intel.com>
> > ---
> >   hw/i386/acpi-build.c | 12 +++++++-----
> >   hw/i386/pc.c         |  9 ---------
> >   include/hw/i386/pc.h |  4 ----
> >   3 files changed, 7 insertions(+), 18 deletions(-)
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>