[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/3] hw/arm/virt: Delete EL3 error checksnow provided in CPU
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 3/3] hw/arm/virt: Delete EL3 error checksnow provided in CPU realize |
Date: |
Mon, 16 Aug 2021 17:10:51 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 8/16/21 3:58 PM, Peter Maydell wrote:
> Now that the CPU realize function will fail cleanly if we ask for EL3
> when KVM is enabled, we don't need to check for errors explicitly in
> the virt board code. The reported message is slightly different;
> it is now:
> qemu-system-aarch64: Cannot enable KVM when guest CPU has EL3 enabled
> instead of:
> qemu-system-aarch64: mach-virt: KVM does not support Security extensions
>
> We don't delete the MTE check because there the logic is more
> complex; deleting the check would work but makes the error message
> less helpful, as it would read:
> qemu-system-aarch64: MTE requested, but not supported by the guest CPU
> instead of:
> qemu-system-aarch64: mach-virt: KVM does not support providing MTE to the
> guest CPU
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/arm/virt.c | 5 -----
> 1 file changed, 5 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- [PATCH 0/3] arm: Avoid asserting in cpu_address_space_init(), Peter Maydell, 2021/08/16
- [PATCH 1/3] raspi: Use error_fatal for SoC realize errors, not error_abort, Peter Maydell, 2021/08/16
- [PATCH 2/3] target/arm: Avoid assertion trying to use KVM and multiple ASes, Peter Maydell, 2021/08/16
- [PATCH 3/3] hw/arm/virt: Delete EL3 error checksnow provided in CPU realize, Peter Maydell, 2021/08/16
- Re: [PATCH 3/3] hw/arm/virt: Delete EL3 error checksnow provided in CPU realize,
Philippe Mathieu-Daudé <=
- Re: [PATCH 0/3] arm: Avoid asserting in cpu_address_space_init(), Richard Henderson, 2021/08/16