Re: [PATCH] vga: don't abort when adding a duplicate isa-vga device

[Jose Ricardo Ziviani]

Hello Thomas and Gerd,

Thank you for reviewing it. Sending a v2 soon.

Thank you very much!

On 16/08/2021 02:05, Gerd Hoffmann wrote:
>    Hi,
>
> > > +    if (qemu_ram_block_by_name("vga.vram")) {
> > > +        error_report("vga.vram is already registered, ignoring this device");
> > > +        return;
> > > +    }
> > I think we should not ignore the error, but rather turn this into a proper
> > error (instead of aborting).
> Yes.  Silently fixing up things automatically tends to be worse long-term.
>
> take care,
>    Gerd