qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3] vhost-vdpa: Do not send empty IOTLB update batches


From: Jason Wang
Subject: Re: [PATCH v3] vhost-vdpa: Do not send empty IOTLB update batches
Date: Mon, 16 Aug 2021 14:00:46 +0800
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0


在 2021/8/16 下午1:36, Michael S. Tsirkin 写道:
On Mon, Aug 16, 2021 at 10:51:57AM +0800, Jason Wang wrote:
On Thu, Aug 12, 2021 at 10:09 PM Eugenio Pérez<eperezma@redhat.com>  wrote:
With the introduction of the batch hinting, meaningless batches can be
created with no IOTLB updates if the memory region was skipped by
vhost_vdpa_listener_skipped_section. This is the case of host notifiers
memory regions, device un/realize, and others. This causes the vdpa
device to receive dma mapping settings with no changes, a possibly
expensive operation for nothing.

To avoid that, VHOST_IOTLB_BATCH_BEGIN hint is delayed until we have a
meaningful (not skipped section) mapping or unmapping operation, and
VHOST_IOTLB_BATCH_END is not written unless at least one of _UPDATE /
_INVALIDATE has been issued.
Acked-by: Jason Wang<jasowang@redhat.com>
Oops. You missed by pull request by a hairwidth.


It's fine.

Thanks





reply via email to

[Prev in Thread] Current Thread [Next in Thread]