Re: [PATCH 3/7] MAINTAINERS: update audio entry.

[Philippe Mathieu-Daudé]

Hi all,

On 8/12/21 2:24 PM, Christian Schoenebeck wrote:
> On Donnerstag, 12. August 2021 10:42:10 CEST Gerd Hoffmann wrote:
>>   Hi,
>>
>>>> On Tue, Aug 10, 2021 at 03:17:43PM +0300, clamky@hotmail.com wrote:
>>>>> Gerd Hoffmann <kraxel@redhat.com> writes:
>>>>>
>>>>> Hell Gerd.
>>>>>
>>>>>> New maintainer wanted. Downgrade status to "Odd Fixes" for now.
>>>>>
>>>>> I can try to retake it.
>>
>> Given your track record is zero contributions to qemu in recent years
>> I suggest you start getting involved in the development process as
>> reviewer.  Just send a patch adding a "R: Name <email>" line for
>> yourself to the MAINTAINERS file (best based on my pending pull
>> request to avoid conflicts).  scripts/get_maintainer.pl will Cc: you
>> on any audio-related patches then.
>>
>> I'd recommend to open an gitlab.com account (unless you already have
>> one of course) so you can help triage bugs + issues.  You can also
>> easily run qemu CI then (just push a branch to a qemu repo fork).
>>
>> HTH & take care,
>>   Gerd
> 
> I will add myself as reviewer for audio to help out a bit at least. I won't 
> be 
> able to take over maintainership at this point though.

Thanks for volunteering :)

Following the overall thread, since I have been wondering about
this subsystem during the night.

As of v6.1.0-rc3:

$ find {,include/}audio -type f | xargs cat | wc -l
11412

$ find {,include/}hw/audio -type f | xargs cat | wc -l
14265

So the backends / frontends have almost the same size.

First idea, split the current entry in too, allowing developers
with different interests to add their contact to the relevant entries.

Then looking at the contribution over the last 10 years:

$ git shortlog -n -s --since=10years -- {,include/}audio | head -10
    70  Kővágó, Zoltán
    62  Volker Rümelin
    24  Gerd Hoffmann
    13  Markus Armbruster
    13  Paolo Bonzini
    10  Peter Maydell
     8  Geoffrey McRae
     8  Philippe Mathieu-Daudé
     8  Stefan Weil
     7  Marc-André Lureau

$ git shortlog -n -s --since=10years -- {,include/}hw/audio | head -10
    30  Gerd Hoffmann
    29  Juan Quintela
    29  Paolo Bonzini
    26  Markus Armbruster
    14  Andreas Färber
    13  Eduardo Habkost
    12  Philippe Mathieu-Daudé
     8  Peter Maydell
     6  Hervé Poussineau
     6  Xiaoqiang Zhao

The backend part is clearly where the activity is (almost no new sound
devices added), with Zoltán Kővágó and Volker Rümelin the most active
contributors. IMHO they certainly deserve an R: tag (but up to them).
Cc'ing them, reminding a R: tag is not about responsibility but more
to not forgot to Cc contributors with both knowledge and interests:

  Descriptions of section entries:

    M: Mail patches to: FullName <address@domain>
       Maintainers are looking after a certain area and must be CCed
       on patches. They are considered the main contact point.
    R: Designated reviewer: FullName <address@domain>
       These reviewers should be CCed on patches.
       Reviewers are familiar with the subject matter and provide
       feedback even though they are not maintainers.

Regards,

Phil.