qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] ui/sdl2: Check return value from g_setenv()


From: Gerd Hoffmann
Subject: Re: [PATCH] ui/sdl2: Check return value from g_setenv()
Date: Tue, 10 Aug 2021 07:50:15 +0200

  Hi,

> Setting environment variables can fail; check the return value
> from g_setenv() and bail out if we couldn't set SDL_VIDEODRIVER.

Hmm, looking at the comment I'm wondering whenever we maybe should just
drop the setenv (after 6.1).  It's quite old, I doubt svgalib talking
directly to the hardware is still a thing these days, and we have the
x11 -> wayland shift happening ...

take care,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]