Re: [PATCH-for-6.2 2/2] target/mips/mxu: Use tcg_constant_i32()

[Richard Henderson]

On 8/8/21 6:08 AM, Philippe Mathieu-Daudé wrote:
> Replace uses of tcg_const_i32() with the allocate and free close together.
>
> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
> ---
>   target/mips/tcg/mxu_translate.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)

In my opinion these functions should be simplified by dropping all of the special casing 
for the zero register and simply let the tcg optimizer do its thing.

But failing that, this is fine.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~