Re: [PATCH v8 08/16] qemu-iotests: add gdbserver option to script tests too

[Emanuele Giuseppe Esposito]

> > diff --git a/tests/qemu-iotests/common.qemu 
> > b/tests/qemu-iotests/common.qemu
> > index 0fc52d20d7..cbca757b49 100644
> > --- a/tests/qemu-iotests/common.qemu
> > +++ b/tests/qemu-iotests/common.qemu
> > @@ -85,7 +85,12 @@ _timed_wait_for()
> >       timeout=yes
> >       QEMU_STATUS[$h]=0
> > -    while IFS= read -t ${QEMU_COMM_TIMEOUT} resp <&${QEMU_OUT[$h]}
> > +    read_timeout="-t ${QEMU_COMM_TIMEOUT}"
> > +    if [ ! -z ${GDB_OPTIONS} ]; then
>
> Shouldn’t we quote "${GDB_OPTIONS}" so that `test` won’t interpret it as 
> its own parameters (if something in there starts with `--`, which I 
> don’t think is the intended usage for $GDB_OPTIONS, but, well...)?
>
> (Also, `! -z` is the same as `-n`, but I suppose choosing between the 
> two can be a matter of style.)

> > +
> > +        GDB=""
> > +        if [ ! -z ${GDB_OPTIONS} ]; then
>
> Here, too.  (Sorry for not noticing in v3 already...)

Sorry, I forgot to reply to this email. I agree, I will put quotes and 
change `! -z` in `-n`.

I will send v9 because after all this time this serie has some minor 
conflicts with current QEMU version.

Hopefully this will be the last one :)

Thank you,
Emanuele