Re: [PATCH-for-6.2 1/2] disas/nios2: Fix style in print_insn_nios2()

[Philippe Mathieu-Daudé]

+Peter for overall style recommendation.

On 8/9/21 8:08 AM, Thomas Huth wrote:
> On 07/08/2021 13.09, Philippe Mathieu-Daudé wrote:
>> We are going to modify this function, fix its style first.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>>   disas/nios2.c | 53 +++++++++++++++++++++++++--------------------------
>>   1 file changed, 26 insertions(+), 27 deletions(-)
> 
> I guess it'd make sense to either re-indent the whole file or to bite
> the bullet and life with the checkpatch warnings here ... otherwise you
> now have one function that matches the QEMU coding style while the rest
> of the file looks completely different.

Yeah I didn't know what to do here, I remember a discussion
(3 years ago?) "disas/..." is old import from binutils libopcode,
so better not diverge the style. But the capstone updates shuffled
things a bit. And nobody is tracking the parent project.
I'm tempted to keep the style and ignore the warnings.

> OTOH, we still can clean that up later, so in case you want to keep this
> patch:
> 
> Reviewed-by: Thomas Huth <thuth@redhat.com>

Thanks.