[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-6.2 02/12] qom: Use DEVICE_*CLASS instead of OBJECT_*CLAS
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH for-6.2 02/12] qom: Use DEVICE_*CLASS instead of OBJECT_*CLASS |
Date: |
Sat, 7 Aug 2021 10:17:17 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 8/6/21 11:11 PM, Eduardo Habkost wrote:
> There are multiple functions where OBJECT_GET_CLASS or
> OBJECT_CLASS_CHECK are being used directly for
> DeviceClass/TYPE_DEVICE, instead of the DEVICE_GET_CLASS or
> DEVICE_CLASS wrappers. There's no reason to not use the
> wrappers, so use them.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Juan Quintela <quintela@redhat.com>
> Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> Cc: Markus Armbruster <armbru@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: "Daniel P. Berrangé" <berrange@redhat.com>
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Cc: qemu-devel@nongnu.org
> ---
> hw/pci/pci.c | 3 +--
> hw/usb/hcd-ehci-pci.c | 2 +-
> migration/savevm.c | 3 +--
> monitor/misc.c | 3 +--
> softmmu/qdev-monitor.c | 3 +--
> 5 files changed, 5 insertions(+), 9 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
- [PATCH for-6.2 00/12] qom: Get rid of all manual usage of OBJECT_CHECK & friends, Eduardo Habkost, 2021/08/06
- [PATCH for-6.2 01/12] accel: Rename TYPE_ACCEL to TYPE_ACCEL_BASE, Eduardo Habkost, 2021/08/06
- [PATCH for-6.2 02/12] qom: Use DEVICE_*CLASS instead of OBJECT_*CLASS, Eduardo Habkost, 2021/08/06
- [PATCH for-6.2 03/12] scripts/codeconverter: Update to latest version, Eduardo Habkost, 2021/08/06
- [PATCH for-6.2 04/12] [automated] Add struct names to typedefs used by QOM types, Eduardo Habkost, 2021/08/06
- [PATCH for-6.2 05/12] [automated] Move QOM typedefs and add missing includes, Eduardo Habkost, 2021/08/06