Re: [PATCH for-6.2 5/6] s390x: event-facility: Use SCLP_EVENT_BUS macro

[Thomas Huth]

On 05/08/2021 21.34, Eduardo Habkost wrote:
> Use the SCLP_EVENT_BUS macro instead of manually calling
> OBJECT_CHECK.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> Cc: Cornelia Huck <cohuck@redhat.com>
> Cc: Thomas Huth <thuth@redhat.com>
> Cc: Halil Pasic <pasic@linux.ibm.com>
> Cc: Christian Borntraeger <borntraeger@de.ibm.com>
> Cc: Richard Henderson <richard.henderson@linaro.org>
> Cc: David Hildenbrand <david@redhat.com>
> Cc: qemu-s390x@nongnu.org
> Cc: qemu-devel@nongnu.org
> ---
>   hw/s390x/event-facility.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/s390x/event-facility.c b/hw/s390x/event-facility.c
> index 9f7883d6e20..bc706bd19b4 100644
> --- a/hw/s390x/event-facility.c
> +++ b/hw/s390x/event-facility.c
> @@ -532,7 +532,7 @@ BusState *sclp_get_event_facility_bus(void)
>       SCLPEventsBus *sbus;
>   
>       busobj = object_resolve_path_type("", TYPE_SCLP_EVENTS_BUS, NULL);
> -    sbus = OBJECT_CHECK(SCLPEventsBus, busobj, TYPE_SCLP_EVENTS_BUS);
> +    sbus = SCLP_EVENT_BUS(busobj);
>       if (!sbus) {
>           return NULL;
>       }

I think this could be merged with the previous patch. Anyway:
Reviewed-by: Thomas Huth <thuth@redhat.com>