qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 02/13] python: disable pylint errors for aqmp-tui


From: John Snow
Subject: Re: [PATCH v3 02/13] python: disable pylint errors for aqmp-tui
Date: Thu, 5 Aug 2021 13:39:14 -0400



On Fri, Jul 30, 2021 at 4:19 PM G S Niteesh Babu <niteesh.gs@gmail.com> wrote:
Disable missing-docstring and fixme pylint warnings.
This is because since the AQMP is just a prototype
it is currently not documented properly and lot
of todo and fixme's are still in place.

Signed-off-by: G S Niteesh Babu <niteesh.gs@gmail.com>
---
 python/setup.cfg | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/python/setup.cfg b/python/setup.cfg
index 2573cd7bfb..7a30dd5b09 100644
--- a/python/setup.cfg
+++ b/python/setup.cfg
@@ -90,6 +90,8 @@ ignore_missing_imports = True
 # --disable=W".
 disable=too-many-function-args,  # mypy handles this with less false positives.
         no-member,  # mypy also handles this better.
+        missing-docstring, # FIXME
+        fixme, # FIXME


Please put some attention into removing the missing-docstring flag. At this point, anything that is "FIXME" should either be fixed or re-worded as a "TODO" and an exemption added to the pylint configuration such that "TODO" is allowed but "FIXME" is not.

Take a look at pylint --generate-rcfile and find this section:

[MISCELLANEOUS]

# List of note tags to take in consideration, separated by a comma.
notes=FIXME,
      XXX,
      TODO
 
 [pylint.basic]
 # Good variable names which should always be accepted, separated by a comma.
--
2.17.1


reply via email to

[Prev in Thread] Current Thread [Next in Thread]