[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 05/10] qapidoc: introduce QAPISchemaIfCond.docgen()
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v7 05/10] qapidoc: introduce QAPISchemaIfCond.docgen() |
Date: |
Thu, 05 Aug 2021 13:55:30 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
marcandre.lureau@redhat.com writes:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Instead of building the condition documentation from a list of string,
> use the result generated from QAPISchemaIfCond.docgen().
>
> This changes the generated documentation from:
> - COND1, COND2... (where COND1, COND2 are Literal nodes, and ',' is Text)
> to:
> - COND1 and COND2 (the whole string as a Literal node)
>
> This will allow us to generate more complex conditions in the following
> patches, such as "(COND1 and COND2) or COND3".
>
> Adding back the differentiated formatting is left to the wish list.
What about a TODO comment? you suggest a suitable spot?
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
- [PATCH v7 00/10] qapi: untie 'if' conditions from C preprocessor, marcandre . lureau, 2021/08/04
- [PATCH v7 01/10] docs: update the documentation upfront about schema configuration, marcandre . lureau, 2021/08/04
- [PATCH v7 02/10] qapi: wrap Sequence[str] in an object, marcandre . lureau, 2021/08/04
- [PATCH v7 03/10] qapi: add QAPISchemaIfCond.is_present(), marcandre . lureau, 2021/08/04
- [PATCH v7 04/10] qapi: introduce QAPISchemaIfCond.cgen(), marcandre . lureau, 2021/08/04
- [PATCH v7 05/10] qapidoc: introduce QAPISchemaIfCond.docgen(), marcandre . lureau, 2021/08/04
- Re: [PATCH v7 05/10] qapidoc: introduce QAPISchemaIfCond.docgen(),
Markus Armbruster <=
- [PATCH v7 06/10] qapi: replace if condition list with dict {'all': [...]}, marcandre . lureau, 2021/08/04
- [PATCH v7 07/10] qapi: add 'any' condition, marcandre . lureau, 2021/08/04
- [PATCH v7 08/10] qapi: Use 'if': { 'any': ... } where appropriate, marcandre . lureau, 2021/08/04