[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 08/11] chardev: fix qemu_chr_open_fd() with fd_in==fd_out
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH v2 08/11] chardev: fix qemu_chr_open_fd() with fd_in==fd_out |
|
Date: |
Thu, 5 Aug 2021 11:40:48 +0100 |
|
User-agent: |
Mutt/2.0.7 (2021-05-04) |
On Wed, Aug 04, 2021 at 07:48:45PM +0400, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> The "serial" chardev calls qemu_chr_open_fd() with the same fd. This
> may lead to double-close as each QIOChannel owns the fd.
>
> Instead, share the reference to the same QIOChannel.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> chardev/char-fd.c | 19 +++++++++++++++----
> 1 file changed, 15 insertions(+), 4 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [PATCH v2 05/11] chardev: mark explicitly first argument as poisoned, (continued)
[PATCH v2 01/11] util: fix abstract socket path copy, marcandre . lureau, 2021/08/04
[PATCH v2 03/11] chardev: remove needless class method, marcandre . lureau, 2021/08/04
[PATCH v2 07/11] chardev: fix qemu_chr_open_fd() being called with fd=-1, marcandre . lureau, 2021/08/04
[PATCH v2 06/11] chardev: fix fd_chr_add_watch() when in != out, marcandre . lureau, 2021/08/04
[PATCH v2 08/11] chardev: fix qemu_chr_open_fd() with fd_in==fd_out, marcandre . lureau, 2021/08/04
- Re: [PATCH v2 08/11] chardev: fix qemu_chr_open_fd() with fd_in==fd_out,
Daniel P . Berrangé <=
[PATCH v2 04/11] chardev: add some comments about the class methods, marcandre . lureau, 2021/08/04
[PATCH v2 02/11] chardev/socket: print a more correct command-line address, marcandre . lureau, 2021/08/04
[PATCH v2 11/11] chardev: reuse qmp_chardev_new(), marcandre . lureau, 2021/08/04
[PATCH v2 09/11] chardev: give some context on chardev-add error, marcandre . lureau, 2021/08/04
[PATCH v2 10/11] chardev: report a simpler error about duplicated id, marcandre . lureau, 2021/08/04