[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-6.2 v4 13/14] machine: Split out the smp parsing code
From: |
Andrew Jones |
Subject: |
Re: [PATCH for-6.2 v4 13/14] machine: Split out the smp parsing code |
Date: |
Tue, 3 Aug 2021 10:28:08 +0200 |
On Tue, Aug 03, 2021 at 04:05:26PM +0800, Yanan Wang wrote:
> We are going to introduce an unit test for the parser smp_parse()
> in hw/core/machine.c, but now machine.c is only built in softmmu.
>
> In order to solve the build dependency on the smp parsing code and
> avoid building unrelated stuff for the unit tests, move the related
> code from machine.c into a new common file, i.e., machine-smp.c.
>
> Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
> ---
> MAINTAINERS | 1 +
> hw/core/machine-smp.c | 199 ++++++++++++++++++++++++++++++++++++++++++
> hw/core/machine.c | 177 -------------------------------------
> hw/core/meson.build | 1 +
> include/hw/boards.h | 1 +
> 5 files changed, 202 insertions(+), 177 deletions(-)
> create mode 100644 hw/core/machine-smp.c
>
Reviewed-by: Andrew Jones <drjones@redhat.com>
- [PATCH for-6.2 v4 07/14] machine: Use ms instead of global current_machine in sanity-check, (continued)
- [PATCH for-6.2 v4 07/14] machine: Use ms instead of global current_machine in sanity-check, Yanan Wang, 2021/08/03
- [PATCH for-6.2 v4 03/14] machine: Set the value of cpus to match maxcpus if it's omitted, Yanan Wang, 2021/08/03
- [PATCH for-6.2 v4 02/14] machine: Uniformly use maxcpus to calculate the omitted parameters, Yanan Wang, 2021/08/03
- [PATCH for-6.2 v4 08/14] machine: Tweak the order of topology members in struct CpuTopology, Yanan Wang, 2021/08/03
- [PATCH for-6.2 v4 11/14] machine: Move smp_prefer_sockets to struct SMPCompatProps, Yanan Wang, 2021/08/03
- [PATCH for-6.2 v4 10/14] machine: Remove smp_parse callback from MachineClass, Yanan Wang, 2021/08/03
- [PATCH for-6.2 v4 01/14] machine: Minor refactor/cleanup for the smp parsers, Yanan Wang, 2021/08/03
- [PATCH for-6.2 v4 13/14] machine: Split out the smp parsing code, Yanan Wang, 2021/08/03
- Re: [PATCH for-6.2 v4 13/14] machine: Split out the smp parsing code,
Andrew Jones <=
- [PATCH for-6.2 v4 06/14] machine: Prefer cores over sockets in smp parsing since 6.2, Yanan Wang, 2021/08/03
- [PATCH for-6.2 v4 14/14] tests/unit: Add a unit test for smp parsing, Yanan Wang, 2021/08/03
- [PATCH for-6.2 v4 09/14] machine: Make smp_parse generic enough for all arches, Yanan Wang, 2021/08/03
- [PATCH for-6.2 v4 12/14] machine: Put all sanity-check in the generic SMP parser, Yanan Wang, 2021/08/03