[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 20/55] accel/tcg: Report unaligned atomics for user-only
From: |
Richard Henderson |
Subject: |
[PATCH v2 20/55] accel/tcg: Report unaligned atomics for user-only |
Date: |
Mon, 2 Aug 2021 18:14:08 -1000 |
Use the newly exposed cpu_unaligned_access for atomic_mmu_lookup,
which has access to complete alignment info from the TCGMemOpIdx arg.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
accel/tcg/user-exec.c | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/accel/tcg/user-exec.c b/accel/tcg/user-exec.c
index 90d1a2d327..5ad808a25a 100644
--- a/accel/tcg/user-exec.c
+++ b/accel/tcg/user-exec.c
@@ -28,6 +28,7 @@
#include "qemu/atomic128.h"
#include "trace/trace-root.h"
#include "trace/mem.h"
+#include "internal.h"
#undef EAX
#undef ECX
@@ -1230,11 +1231,22 @@ static void *atomic_mmu_lookup(CPUArchState *env,
target_ulong addr,
TCGMemOpIdx oi, int size, int prot,
uintptr_t retaddr)
{
+ MemOp mop = get_memop(oi);
+ int a_bits = get_alignment_bits(mop);
+ void *ret;
+
+ /* Enforce guest required alignment. */
+ if (unlikely(addr & ((1 << a_bits) - 1))) {
+ MMUAccessType t = prot == PAGE_READ ? MMU_DATA_LOAD : MMU_DATA_STORE;
+ cpu_unaligned_access(env_cpu(env), addr, t, get_mmuidx(oi), retaddr);
+ }
+
/* Enforce qemu required alignment. */
if (unlikely(addr & (size - 1))) {
cpu_loop_exit_atomic(env_cpu(env), retaddr);
}
- void *ret = g2h(env_cpu(env), addr);
+
+ ret = g2h(env_cpu(env), addr);
set_helper_retaddr(retaddr);
return ret;
}
--
2.25.1
- [PATCH v2 16/55] target/sparc: Split out build_sfsr, (continued)
- [PATCH v2 16/55] target/sparc: Split out build_sfsr, Richard Henderson, 2021/08/03
- [PATCH v2 12/55] target/s390x: Implement do_unaligned_access for user-only, Richard Henderson, 2021/08/03
- [PATCH v2 15/55] target/sparc: Remove DEBUG_UNALIGNED, Richard Henderson, 2021/08/03
- [PATCH v2 17/55] target/sparc: Set fault address in sparc_cpu_do_unaligned_access, Richard Henderson, 2021/08/03
- [PATCH v2 18/55] target/sparc: Implement do_unaligned_access for user-only, Richard Henderson, 2021/08/03
- [PATCH v2 20/55] accel/tcg: Report unaligned atomics for user-only,
Richard Henderson <=
- [PATCH v2 21/55] accel/tcg: Drop signness in tracing in cputlb.c, Richard Henderson, 2021/08/03
- [PATCH v2 19/55] target/xtensa: Implement do_unaligned_access for user-only, Richard Henderson, 2021/08/03
- [PATCH v2 22/55] tcg: Expand MO_SIZE to 3 bits, Richard Henderson, 2021/08/03
- [PATCH v2 24/55] tcg: Split out MemOpIdx to exec/memopidx.h, Richard Henderson, 2021/08/03