[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 3/7] usbredir: fix free call
From: |
Gerd Hoffmann |
Subject: |
[PULL 3/7] usbredir: fix free call |
Date: |
Thu, 29 Jul 2021 14:50:40 +0200 |
data might point into the middle of a larger buffer, there is a separate
free_on_destroy pointer passed into bufp_alloc() to handle that. It is
only used in the normal workflow though, not when dropping packets due
to the queue being full. Fix that.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/491
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20210722072756.647673-1-kraxel@redhat.com>
---
hw/usb/redirect.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c
index 4ec9326e0582..1ec909a63a80 100644
--- a/hw/usb/redirect.c
+++ b/hw/usb/redirect.c
@@ -476,7 +476,7 @@ static int bufp_alloc(USBRedirDevice *dev, uint8_t *data,
uint16_t len,
if (dev->endpoint[EP2I(ep)].bufpq_dropping_packets) {
if (dev->endpoint[EP2I(ep)].bufpq_size >
dev->endpoint[EP2I(ep)].bufpq_target_size) {
- free(data);
+ free(free_on_destroy);
return -1;
}
dev->endpoint[EP2I(ep)].bufpq_dropping_packets = 0;
--
2.31.1
- [PULL 0/7] Usb 20210729 patches, Gerd Hoffmann, 2021/07/29
- [PULL 1/7] usb-host: wire up timer for windows, Gerd Hoffmann, 2021/07/29
- [PULL 4/7] docs: Incorporate information in usb-storage.txt into rST manual, Gerd Hoffmann, 2021/07/29
- [PULL 2/7] ci: add libusb for windows builds, Gerd Hoffmann, 2021/07/29
- [PULL 3/7] usbredir: fix free call,
Gerd Hoffmann <=
- [PULL 5/7] docs: Fold usb2.txt USB controller information into usb.rst, Gerd Hoffmann, 2021/07/29
- [PULL 6/7] docs: Fold usb2.txt physical port addressing info into usb.rst, Gerd Hoffmann, 2021/07/29
- [PULL 7/7] docs: Fold usb2.txt passthrough information into usb.rst, Gerd Hoffmann, 2021/07/29
- Re: [PULL 0/7] Usb 20210729 patches, Peter Maydell, 2021/07/30