[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-6.2 v3 06/11] machine: Prefer cores over sockets in smp p
From: |
Cornelia Huck |
Subject: |
Re: [PATCH for-6.2 v3 06/11] machine: Prefer cores over sockets in smp parsing since 6.2 |
Date: |
Thu, 29 Jul 2021 11:12:05 +0200 |
User-agent: |
Notmuch/0.32.1 (https://notmuchmail.org) |
On Wed, Jul 28 2021, Yanan Wang <wangyanan55@huawei.com> wrote:
> In the real SMP hardware topology world, it's much more likely that
> we have high cores-per-socket counts and few sockets totally. While
> the current preference of sockets over cores in smp parsing results
> in a virtual cpu topology with low cores-per-sockets counts and a
> large number of sockets, which is just contrary to the real world.
>
> Given that it is better to make the virtual cpu topology be more
> reflective of the real world and also for the sake of compatibility,
> we start to prefer cores over sockets over threads in smp parsing
> since machine type 6.2 for different arches.
>
> In this patch, a boolean "smp_prefer_sockets" is added, and we only
> enable the old preference on older machines and enable the new one
> since type 6.2 for all arches by using the machine compat mechanism.
>
> Acked-by: David Gibson <david@gibson.dropbear.id.au>
> Suggested-by: Daniel P. Berrange <berrange@redhat.com>
> Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
> ---
> hw/arm/virt.c | 1 +
> hw/core/machine.c | 36 ++++++++++++++++++++++++++----------
> hw/i386/pc.c | 36 ++++++++++++++++++++++++++----------
> hw/i386/pc_piix.c | 1 +
> hw/i386/pc_q35.c | 1 +
> hw/ppc/spapr.c | 1 +
> hw/s390x/s390-virtio-ccw.c | 1 +
> include/hw/boards.h | 1 +
> qemu-options.hx | 3 ++-
> 9 files changed, 60 insertions(+), 21 deletions(-)
Acked-by: Cornelia Huck <cohuck@redhat.com>
- [PATCH for-6.2 v3 10/11] machine: Remove smp_parse callback from MachineClass, (continued)
- [PATCH for-6.2 v3 10/11] machine: Remove smp_parse callback from MachineClass, Yanan Wang, 2021/07/27
- [PATCH for-6.2 v3 09/11] machine: Make smp_parse generic enough for all arches, Yanan Wang, 2021/07/27
- [PATCH for-6.2 v3 03/11] machine: Set the value of cpus to match maxcpus if it's omitted, Yanan Wang, 2021/07/27
- [PATCH for-6.2 v3 06/11] machine: Prefer cores over sockets in smp parsing since 6.2, Yanan Wang, 2021/07/27
- [PATCH for-6.2 v3 11/11] machine: Move smp_prefer_sockets to struct SMPCompatProps, Yanan Wang, 2021/07/27